From bce5fcf21819715e9d2744aa9a7d6457dd9362fd Mon Sep 17 00:00:00 2001
From: TacoTheDank <SkytkRSfan3895@gmail.com>
Date: Fri, 10 Jul 2020 20:03:11 -0400
Subject: [PATCH] Better support rtl

---
 app/src/main/AndroidManifest.xml              |  3 ++-
 .../res/layout-land/dialog_color_picker.xml   |  2 +-
 .../main/res/layout/actionbar_donebutton.xml  |  1 +
 .../res/layout/actionbar_serverstatus.xml     |  2 ++
 app/src/main/res/layout/dialog_about.xml      |  1 +
 .../main/res/layout/dialog_color_picker.xml   |  4 ++--
 .../main/res/layout/dialog_transferrates.xml  |  8 +++++--
 .../res/layout/fragment_details_header.xml    | 24 ++++++++++++++++++-
 app/src/main/res/layout/list_item_torrent.xml |  1 +
 app/src/main/res/layout/list_item_widget.xml  |  7 ++++++
 .../main/res/layout/list_item_widget_dark.xml |  7 ++++++
 app/src/main/res/layout/pref_withoverflow.xml |  2 +-
 app/src/main/res/layout/widget_torrents.xml   | 10 ++++++++
 13 files changed, 64 insertions(+), 8 deletions(-)

diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
index 3b195fac..2873ea14 100644
--- a/app/src/main/AndroidManifest.xml
+++ b/app/src/main/AndroidManifest.xml
@@ -54,6 +54,7 @@
         android:hardwareAccelerated="true"
         android:icon="@drawable/ic_launcher"
         android:label="@string/app_name"
+        android:supportsRtl="true"
         android:theme="@style/Theme.AppCompat"
         android:usesCleartextTraffic="true">
 
@@ -192,7 +193,7 @@
         <activity
             android:name="org.transdroid.core.gui.DetailsActivity_"
             android:theme="@style/TransdroidTheme"
-            android:uiOptions="splitActionBarWhenNarrow"></activity>
+            android:uiOptions="splitActionBarWhenNarrow" />
 
         <!-- Settings screens -->
         <activity
diff --git a/app/src/main/res/layout-land/dialog_color_picker.xml b/app/src/main/res/layout-land/dialog_color_picker.xml
index e6dc4bc4..3f01c21b 100644
--- a/app/src/main/res/layout-land/dialog_color_picker.xml
+++ b/app/src/main/res/layout-land/dialog_color_picker.xml
@@ -44,7 +44,7 @@
             android:inputType="textCapCharacters"
             android:maxLength="7"
             android:singleLine="true"
-            android:visibility="gone"></EditText>
+            android:visibility="gone" />
 
         <TextView
             android:layout_width="wrap_content"
diff --git a/app/src/main/res/layout/actionbar_donebutton.xml b/app/src/main/res/layout/actionbar_donebutton.xml
index 7eeff5d2..f85ec4a4 100644
--- a/app/src/main/res/layout/actionbar_donebutton.xml
+++ b/app/src/main/res/layout/actionbar_donebutton.xml
@@ -27,6 +27,7 @@
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:layout_gravity="center"
+        android:drawableStart="@drawable/ic_action_done"
         android:drawableLeft="@drawable/ic_action_done"
         android:drawablePadding="8dp"
         android:gravity="center_vertical"
diff --git a/app/src/main/res/layout/actionbar_serverstatus.xml b/app/src/main/res/layout/actionbar_serverstatus.xml
index 382e3828..ec52ac19 100644
--- a/app/src/main/res/layout/actionbar_serverstatus.xml
+++ b/app/src/main/res/layout/actionbar_serverstatus.xml
@@ -91,7 +91,9 @@
             android:layout_width="@dimen/ui_serverstatus_width"
             android:layout_height="wrap_content"
             android:layout_below="@id/downcount_text"
+            android:layout_alignStart="@id/downcount_text"
             android:layout_alignLeft="@id/downcount_text"
+            android:layout_alignEnd="@id/downcount_sign"
             android:layout_alignRight="@id/downcount_sign"
             android:layout_marginTop="-4dip"
             android:fontFamily="sans-serif-light"
diff --git a/app/src/main/res/layout/dialog_about.xml b/app/src/main/res/layout/dialog_about.xml
index eb09ce5e..9c607bfb 100644
--- a/app/src/main/res/layout/dialog_about.xml
+++ b/app/src/main/res/layout/dialog_about.xml
@@ -31,6 +31,7 @@
             android:layout_gravity="center_horizontal"
             android:layout_marginTop="@dimen/margin_half"
             android:layout_marginBottom="@dimen/margin_half"
+            android:drawableStart="@drawable/ic_launcher"
             android:drawableLeft="@drawable/ic_launcher"
             android:drawablePadding="@dimen/margin_half"
             android:fontFamily="sans-serif-condensed"
diff --git a/app/src/main/res/layout/dialog_color_picker.xml b/app/src/main/res/layout/dialog_color_picker.xml
index 3f2e4409..9138e863 100644
--- a/app/src/main/res/layout/dialog_color_picker.xml
+++ b/app/src/main/res/layout/dialog_color_picker.xml
@@ -40,7 +40,7 @@
         <TextView
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
-            android:gravity="left"
+            android:gravity="start"
             android:text="@string/press_color_to_apply"
             android:textAppearance="?android:attr/textAppearanceSmall" />
 
@@ -54,7 +54,7 @@
             android:inputType="textCapCharacters"
             android:maxLength="7"
             android:singleLine="true"
-            android:visibility="gone"></EditText>
+            android:visibility="gone" />
     </LinearLayout>
 
     <LinearLayout
diff --git a/app/src/main/res/layout/dialog_transferrates.xml b/app/src/main/res/layout/dialog_transferrates.xml
index 6c7f7132..a6391bf3 100644
--- a/app/src/main/res/layout/dialog_transferrates.xml
+++ b/app/src/main/res/layout/dialog_transferrates.xml
@@ -30,6 +30,7 @@
         <TextView
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
+            android:layout_marginEnd="@dimen/margin_half"
             android:layout_marginRight="@dimen/margin_half"
             android:text="@string/status_maxspeed_down"
             android:textAllCaps="true" />
@@ -40,13 +41,14 @@
             android:layout_width="0dip"
             android:layout_height="wrap_content"
             android:layout_weight="1"
-            android:gravity="right"
+            android:gravity="end"
             android:singleLine="true"
             android:text="@string/status_maxspeed_novalue" />
 
         <TextView
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
+            android:layout_marginEnd="@dimen/margin_half"
             android:layout_marginRight="@dimen/margin_half"
             android:text="@string/status_maxspeed_unit"
             android:textAllCaps="true" />
@@ -174,6 +176,7 @@
         <TextView
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
+            android:layout_marginEnd="@dimen/margin_half"
             android:layout_marginRight="@dimen/margin_half"
             android:text="@string/status_maxspeed_up"
             android:textAllCaps="true" />
@@ -184,13 +187,14 @@
             android:layout_width="0dip"
             android:layout_height="wrap_content"
             android:layout_weight="1"
-            android:gravity="right"
+            android:gravity="end"
             android:singleLine="true"
             android:text="@string/status_maxspeed_novalue" />
 
         <TextView
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
+            android:layout_marginEnd="@dimen/margin_half"
             android:layout_marginRight="@dimen/margin_half"
             android:text="@string/status_maxspeed_unit"
             android:textAllCaps="true" />
diff --git a/app/src/main/res/layout/fragment_details_header.xml b/app/src/main/res/layout/fragment_details_header.xml
index bf95110e..8021f283 100644
--- a/app/src/main/res/layout/fragment_details_header.xml
+++ b/app/src/main/res/layout/fragment_details_header.xml
@@ -32,6 +32,7 @@
             android:id="@+id/dateadded_text"
             android:layout_width="0dp"
             android:layout_height="wrap_content"
+            android:layout_marginEnd="@dimen/margin_half"
             android:layout_marginRight="@dimen/margin_half"
             android:layout_weight="0.5"
             android:textIsSelectable="false" />
@@ -41,9 +42,10 @@
             style="@style/LabelTextView"
             android:layout_width="0dp"
             android:layout_height="wrap_content"
+            android:layout_marginStart="@dimen/margin_half"
             android:layout_marginLeft="@dimen/margin_half"
             android:layout_weight="0.5"
-            android:gravity="right"
+            android:gravity="end"
             android:textIsSelectable="true"
             android:visibility="invisible" />
     </LinearLayout>
@@ -64,8 +66,10 @@
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:layout_below="@id/date_label_wrapper"
+        android:layout_marginStart="@dimen/margin_half"
         android:layout_marginLeft="@dimen/margin_half"
         android:layout_marginTop="@dimen/margin_half"
+        android:layout_toEndOf="@id/separator"
         android:layout_toRightOf="@id/separator"
         android:fontFamily="sans-serif-light"
         android:textColor="?attr/text_bright"
@@ -77,7 +81,9 @@
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:layout_alignBaseline="@id/uploaded_text"
+        android:layout_marginStart="4dip"
         android:layout_marginLeft="4dip"
+        android:layout_toEndOf="@id/uploaded_text"
         android:layout_toRightOf="@id/uploaded_text"
         android:fontFamily="sans-serif-light"
         android:textColor="?attr/text_bright"
@@ -88,7 +94,9 @@
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:layout_below="@id/uploaded_text"
+        android:layout_marginStart="@dimen/margin_half"
         android:layout_marginLeft="@dimen/margin_half"
+        android:layout_toEndOf="@id/separator"
         android:layout_toRightOf="@id/separator"
         android:textIsSelectable="false"
         android:textSize="@dimen/text_small" />
@@ -98,8 +106,10 @@
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:layout_below="@id/ratio_text"
+        android:layout_marginStart="@dimen/margin_half"
         android:layout_marginLeft="@dimen/margin_half"
         android:layout_marginBottom="4dip"
+        android:layout_toEndOf="@id/separator"
         android:layout_toRightOf="@id/separator"
         android:fontFamily="sans-serif-light"
         android:textColor="?attr/text_bright"
@@ -111,7 +121,9 @@
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:layout_below="@id/upspeed_text"
+        android:layout_marginStart="@dimen/margin_half"
         android:layout_marginLeft="@dimen/margin_half"
+        android:layout_toEndOf="@id/separator"
         android:layout_toRightOf="@id/separator"
         android:textIsSelectable="false"
         android:textSize="@dimen/text_small" />
@@ -121,7 +133,9 @@
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:layout_alignBaseline="@id/uploadedunit_text"
+        android:layout_marginEnd="@dimen/margin_half"
         android:layout_marginRight="@dimen/margin_half"
+        android:layout_toStartOf="@id/separator"
         android:layout_toLeftOf="@id/separator"
         android:fontFamily="sans-serif-light"
         android:textColor="?attr/text_bright"
@@ -132,7 +146,9 @@
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:layout_alignBaseline="@id/uploadedunit_text"
+        android:layout_marginEnd="4dip"
         android:layout_marginRight="4dip"
+        android:layout_toStartOf="@id/downloadedunit_text"
         android:layout_toLeftOf="@id/downloadedunit_text"
         android:fontFamily="sans-serif-light"
         android:textColor="?attr/text_bright"
@@ -144,7 +160,9 @@
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:layout_alignBaseline="@id/ratio_text"
+        android:layout_marginEnd="@dimen/margin_half"
         android:layout_marginRight="@dimen/margin_half"
+        android:layout_toStartOf="@id/separator"
         android:layout_toLeftOf="@id/separator"
         android:textIsSelectable="false"
         android:textSize="@dimen/text_small" />
@@ -154,7 +172,9 @@
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:layout_alignBaseline="@id/upspeed_text"
+        android:layout_marginEnd="@dimen/margin_half"
         android:layout_marginRight="@dimen/margin_half"
+        android:layout_toStartOf="@id/separator"
         android:layout_toLeftOf="@id/separator"
         android:fontFamily="sans-serif-light"
         android:textColor="?attr/text_bright"
@@ -166,7 +186,9 @@
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:layout_alignBaseline="@id/leechers_text"
+        android:layout_marginEnd="@dimen/margin_half"
         android:layout_marginRight="@dimen/margin_half"
+        android:layout_toStartOf="@id/separator"
         android:layout_toLeftOf="@id/separator"
         android:textIsSelectable="false"
         android:textSize="@dimen/text_small" />
diff --git a/app/src/main/res/layout/list_item_torrent.xml b/app/src/main/res/layout/list_item_torrent.xml
index 22de5626..2b1de10a 100644
--- a/app/src/main/res/layout/list_item_torrent.xml
+++ b/app/src/main/res/layout/list_item_torrent.xml
@@ -82,6 +82,7 @@
         android:layout_width="fill_parent"
         android:layout_height="wrap_content"
         android:layout_below="@id/ratio_text"
+        android:layout_marginStart="@dimen/margin_torrentlistleft"
         android:layout_marginLeft="@dimen/margin_torrentlistleft"
         android:layout_marginTop="@dimen/margin_half" />
 
diff --git a/app/src/main/res/layout/list_item_widget.xml b/app/src/main/res/layout/list_item_widget.xml
index 5b986d2b..68b5d76a 100644
--- a/app/src/main/res/layout/list_item_widget.xml
+++ b/app/src/main/res/layout/list_item_widget.xml
@@ -19,6 +19,7 @@
     android:layout_width="fill_parent"
     android:layout_height="@dimen/widget_list_item_height"
     android:background="?android:attr/selectableItemBackground"
+    android:paddingEnd="@dimen/widget_list_item_padding"
     android:paddingRight="@dimen/widget_list_item_padding">
 
     <TextView
@@ -30,6 +31,7 @@
         android:id="@+id/name_text"
         android:layout_width="fill_parent"
         android:layout_height="wrap_content"
+        android:layout_marginStart="@dimen/widget_list_item_padding_left"
         android:layout_marginLeft="@dimen/widget_list_item_padding_left"
         android:ellipsize="end"
         android:fontFamily="sans-serif-condensed"
@@ -44,7 +46,9 @@
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:layout_below="@id/name_text"
+        android:layout_alignParentEnd="true"
         android:layout_alignParentRight="true"
+        android:layout_marginStart="@dimen/widget_list_item_padding"
         android:layout_marginLeft="@dimen/widget_list_item_padding"
         android:layout_marginTop="4dip"
         android:maxLines="1"
@@ -58,8 +62,11 @@
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:layout_alignBaseline="@id/ratio_text"
+        android:layout_alignParentStart="true"
         android:layout_alignParentLeft="true"
+        android:layout_marginStart="@dimen/widget_list_item_padding_left"
         android:layout_marginLeft="@dimen/widget_list_item_padding_left"
+        android:layout_toStartOf="@id/ratio_text"
         android:layout_toLeftOf="@id/ratio_text"
         android:maxLines="1"
         android:textColor="@color/transdroid_text_bright"
diff --git a/app/src/main/res/layout/list_item_widget_dark.xml b/app/src/main/res/layout/list_item_widget_dark.xml
index 4ec25206..b9b1e4d3 100644
--- a/app/src/main/res/layout/list_item_widget_dark.xml
+++ b/app/src/main/res/layout/list_item_widget_dark.xml
@@ -19,6 +19,7 @@
     android:layout_width="fill_parent"
     android:layout_height="@dimen/widget_list_item_height"
     android:background="?android:attr/selectableItemBackground"
+    android:paddingEnd="@dimen/widget_list_item_padding"
     android:paddingRight="@dimen/widget_list_item_padding">
 
     <TextView
@@ -30,6 +31,7 @@
         android:id="@+id/name_text"
         android:layout_width="fill_parent"
         android:layout_height="wrap_content"
+        android:layout_marginStart="@dimen/widget_list_item_padding_left"
         android:layout_marginLeft="@dimen/widget_list_item_padding_left"
         android:ellipsize="end"
         android:fontFamily="sans-serif-condensed"
@@ -44,7 +46,9 @@
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:layout_below="@id/name_text"
+        android:layout_alignParentEnd="true"
         android:layout_alignParentRight="true"
+        android:layout_marginStart="@dimen/widget_list_item_padding"
         android:layout_marginLeft="@dimen/widget_list_item_padding"
         android:layout_marginTop="4dip"
         android:maxLines="1"
@@ -58,8 +62,11 @@
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:layout_alignBaseline="@id/ratio_text"
+        android:layout_alignParentStart="true"
         android:layout_alignParentLeft="true"
+        android:layout_marginStart="@dimen/widget_list_item_padding_left"
         android:layout_marginLeft="@dimen/widget_list_item_padding_left"
+        android:layout_toStartOf="@id/ratio_text"
         android:layout_toLeftOf="@id/ratio_text"
         android:maxLines="1"
         android:textColor="@color/transdroid_dark_text_bright"
diff --git a/app/src/main/res/layout/pref_withoverflow.xml b/app/src/main/res/layout/pref_withoverflow.xml
index 5fee1354..87849e02 100644
--- a/app/src/main/res/layout/pref_withoverflow.xml
+++ b/app/src/main/res/layout/pref_withoverflow.xml
@@ -7,7 +7,7 @@
         android:id="@+id/overflow_button"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
-        android:layout_gravity="right|center_vertical"
+        android:layout_gravity="end|center_vertical"
         android:background="?android:attr/selectableItemBackground"
         android:contentDescription="@string/pref_addseedbox"
         android:padding="5dp"
diff --git a/app/src/main/res/layout/widget_torrents.xml b/app/src/main/res/layout/widget_torrents.xml
index e844e5c6..fd1601b3 100644
--- a/app/src/main/res/layout/widget_torrents.xml
+++ b/app/src/main/res/layout/widget_torrents.xml
@@ -44,6 +44,7 @@
             android:layout_weight="1"
             android:background="?android:attr/selectableItemBackground"
             android:clickable="true"
+            android:focusable="true"
             android:orientation="vertical"
             android:paddingTop="3dp"
             android:paddingEnd="@dimen/margin_half"
@@ -82,6 +83,7 @@
             android:layout_weight="1"
             android:background="?android:attr/selectableItemBackground"
             android:clickable="true"
+            android:focusable="true"
             android:paddingTop="@dimen/ui_serverstatus_margin"
             android:visibility="gone">
 
@@ -89,6 +91,7 @@
                 android:id="@+id/upcount_sign"
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
+                android:layout_alignParentEnd="true"
                 android:layout_alignParentRight="true"
                 android:fontFamily="sans-serif-light"
                 android:paddingTop="@dimen/ui_serverstatus_signmargin"
@@ -100,6 +103,7 @@
                 android:id="@+id/upcount_text"
                 android:layout_width="@dimen/ui_serverstatus_width"
                 android:layout_height="wrap_content"
+                android:layout_toStartOf="@id/upcount_sign"
                 android:layout_toLeftOf="@id/upcount_sign"
                 android:fontFamily="sans-serif-light"
                 android:gravity="end"
@@ -109,6 +113,7 @@
                 android:id="@+id/downcount_sign"
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
+                android:layout_toStartOf="@id/upcount_text"
                 android:layout_toLeftOf="@id/upcount_text"
                 android:fontFamily="sans-serif-light"
                 android:paddingTop="@dimen/ui_serverstatus_signmargin"
@@ -120,6 +125,7 @@
                 android:id="@+id/downcount_text"
                 android:layout_width="@dimen/ui_serverstatus_width"
                 android:layout_height="wrap_content"
+                android:layout_toStartOf="@id/downcount_sign"
                 android:layout_toLeftOf="@id/downcount_sign"
                 android:fontFamily="sans-serif-light"
                 android:gravity="end"
@@ -130,7 +136,9 @@
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
                 android:layout_below="@id/upcount_text"
+                android:layout_alignStart="@id/upcount_text"
                 android:layout_alignLeft="@id/upcount_text"
+                android:layout_alignParentEnd="true"
                 android:layout_alignParentRight="true"
                 android:layout_marginTop="-4dip"
                 android:fontFamily="sans-serif-light"
@@ -142,7 +150,9 @@
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
                 android:layout_below="@id/downcount_text"
+                android:layout_alignStart="@id/downcount_text"
                 android:layout_alignLeft="@id/downcount_text"
+                android:layout_alignEnd="@id/downcount_sign"
                 android:layout_alignRight="@id/downcount_sign"
                 android:layout_marginTop="-4dip"
                 android:fontFamily="sans-serif-light"